Eliminate some allocations in ReadFrom/WriteTo #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
force-pushed
the
no-more-buffered-io
branch
from
fe4ce10 to
30bd877
Compare
omerfirmak
force-pushed
the
no-more-buffered-io
branch
from
30bd877 to
99be40f
Compare
|
Very, very good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
Before
BenchmarkBitsetReadWrite-16 33740 52474 ns/op 8409 B/op 12 allocs/opAfter
BenchmarkBitsetReadWrite-16 55478 21935 ns/op 16 B/op 2 allocs/op